Hey all,
I just received an email from Google saying that they couldn't send notifications to our callback URL: gcCallback.aspx. Strange, since we haven't changed anything about our GoogleCheckout configuration in a very long time.
I tried accessing the program from a browser and, sure enough, I get asked for login credentials. I double-checked that our GoogleCheckout.AuthenticateCallback appconfig value is set to False - it is. Out of curiosity, I traced back the code to GoogleCheckout.cs to see what it does and I see this:
Code:
public static bool VerifyMessageAuthentication(string authStr)
{
if (AppLogic.AppConfigBool("GoogleCheckout.AuthenticateCallback"))
{ //v7 If not required to Authenticate then just return saying everything is good.
return true;
}...
This code appears to be doing the opposite of what the comment is saying, right? The code is returning true (and bypassing the authentication code later in the function) if GoogleCheckout.AuthenticateCallback is true.
To make sure I wasn't losing it, I changed the GoogleCheckout.AuthenticateCallback appconfig to True (which I've never done before) and tried to run gcCallback.aspx from a browser. No login prompt! So I can only assume that this code in VerifyMessageAuthentication is incorrect and should be changed, and our AspDotNetStorefrontGateways.dll recompiled and deployed.
Can I get confirmation from a StoreFront architect that this is the right thing to do? Do I have an old/bad version of the VerifyMessageAuthentication function?
Thanks!
Kevin
Home Security Store